iffyio commented on code in PR #2041:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2041#discussion_r2382550074
##########
tests/sqlparser_common.rs:
##########
@@ -16533,6 +16537,40 @@ fn parse_create_procedure_with_parameter_modes() {
}
}
+#[test]
+fn create_procedure_with_parameter_default_value() {
+ let sql = r#"CREATE PROCEDURE test_proc (a INT = 42) AS BEGIN SELECT 1;
END"#;
Review Comment:
Can we add scenarios demonstrating
- multiple paramenters having defaults (i.e. `(a INT= 42, b INT=43)`)
- parameters that include a `mode`
##########
tests/sqlparser_common.rs:
##########
@@ -16533,6 +16537,40 @@ fn parse_create_procedure_with_parameter_modes() {
}
}
+#[test]
+fn create_procedure_with_parameter_default_value() {
Review Comment:
Can we merge the test into the existing
`parse_create_procedure_with_parameter_modes`? since they cover the same feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
