andygrove commented on PR #2429: URL: https://github.com/apache/datafusion-comet/pull/2429#issuecomment-3335839655
I found that we fall back to Spark when there are multiple count distinct e.g. ``` test("mulitple count distinct with group column") { val df = spark.read.parquet(filename) df.createOrReplaceTempView("t1") val sql = s"SELECT c1, count(distinct c2), count(distinct c3) FROM t1 group by c1" val (_, cometPlan) = checkSparkAnswer(sql) if (usingDataSourceExec) { assert(1 == collectNativeScans(cometPlan).length) } } ``` This isn't an issue for this PR, but thought I should make a note of this. ``` Comet cannot accelerate HashAggregateExec because: Aggregate expression with filter is not supported ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org