mbutrovich commented on code in PR #2447:
URL: https://github.com/apache/datafusion-comet/pull/2447#discussion_r2373571298
##########
native/core/src/parquet/parquet_exec.rs:
##########
@@ -122,9 +145,131 @@ pub(crate) fn init_datasource_exec(
Ok(Arc::new(DataSourceExec::new(Arc::new(file_scan_config))))
}
+pub const ENCRYPTION_FACTORY_ID: &str = "comet.jni_kms_encryption";
+
+// Options used to configure our example encryption factory
+extensions_options! {
+ struct CometEncryptionConfig {
+ url_base: String, default = "file:///".into()
+ }
+}
+#[derive(Debug)]
+pub struct CometEncryptionFactory {
+ pub(crate) key_unwrapper: GlobalRef,
+}
+
+/// `EncryptionFactory` is a DataFusion trait for types that generate
+/// file encryption and decryption properties.
+#[async_trait]
+impl EncryptionFactory for CometEncryptionFactory {
+ async fn get_file_encryption_properties(
+ &self,
+ _options: &EncryptionFactoryOptions,
+ _schema: &SchemaRef,
+ _file_path: &Path,
+ ) -> Result<Option<FileEncryptionProperties>, DataFusionError> {
+ Err(DataFusionError::NotImplemented(
+ "Comet does not support Parquet encryption yet."
Review Comment:
Correct. Comet does not support write path at all. When the time comes, PME
is already supported in DataFusion and Arrow-rs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
