hsiang-c commented on code in PR #2447:
URL: https://github.com/apache/datafusion-comet/pull/2447#discussion_r2373388517
##########
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##########
@@ -410,6 +410,16 @@ public void init() throws Throwable {
}
}
+ boolean encryptionEnabled =
+ !conf.get("parquet.crypto.factory.class").isEmpty()
Review Comment:
`conf.get` returns `null` if no such property exists, so we might need a
null check as well.
##########
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##########
@@ -410,6 +410,16 @@ public void init() throws Throwable {
}
}
+ boolean encryptionEnabled =
+ !conf.get("parquet.crypto.factory.class").isEmpty()
Review Comment:
(nit) Maybe we can use
`DecryptionPropertiesFactory.CRYPTO_FACTORY_CLASS_PROPERTY_NAME` and
`KeyToolkit.KMS_CLIENT_CLASS_PROPERTY_NAME`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
