ntjohnson1 commented on PR #1248: URL: https://github.com/apache/datafusion-python/pull/1248#issuecomment-3323400431
> It doesn't look like there are any actual changes here? You're just switching to not use `&mut`? Correct. Basically marked the class as frozen to make sure no `mut self` accidentally creep in. When not `mut self` then python threads are enabled since we aren't trying to borrow mutable versions of the python wrapper twice. Then I believe the rust compiler verifies nothing deeper in the accesses actual needed a mutable version of the rust Session Context and are safe for concurrency (things are `Arc` etc all the way down). > I think a better PR description might be "Make pyclasses frozen to use our own interior mutability" Updated the description. Can update to your suggestion verbatim if still unclear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
