coderfender commented on code in PR #2430:
URL: https://github.com/apache/datafusion-comet/pull/2430#discussion_r2366384574
##########
.github/actions/java-test/action.yaml:
##########
@@ -82,6 +82,21 @@ runs:
MAVEN_SUITES="$(echo "${{ inputs.suites }}" | paste -sd, -)"
echo "Running with MAVEN_SUITES=$MAVEN_SUITES"
MAVEN_OPTS="-Xmx4G -Xms2G -DwildcardSuites=$MAVEN_SUITES
-XX:+UnlockDiagnosticVMOptions -XX:+ShowMessageBoxOnError
-XX:+HeapDumpOnOutOfMemoryError -XX:ErrorFile=./hs_err_pid%p.log"
SPARK_HOME=`pwd` ./mvnw -B clean install ${{ inputs.maven_opts }}
+
+ - name: Check for documentation changes
+ shell: bash
+ run: |
+ # Check if any files in docs/ have been modified after Maven build
(which runs GenerateDocs)
+ if [ -n "$(git status --porcelain -- docs/)" ]; then
+ echo "❌ Documentation files have been modified after Maven build:"
+ git diff --name-only -- docs/
+ echo ""
+ echo "This suggests that config defaults have changed but the
documentation wasn't updated."
+ echo "Please run 'make jvm' locally and commit the updated
documentation files."
+ exit 1
+ else
+ echo "✅ Documentation is up-to-date"
Review Comment:
Minor nitpick to probably remove the emojis
##########
.github/actions/java-test/action.yaml:
##########
@@ -82,6 +82,21 @@ runs:
MAVEN_SUITES="$(echo "${{ inputs.suites }}" | paste -sd, -)"
echo "Running with MAVEN_SUITES=$MAVEN_SUITES"
MAVEN_OPTS="-Xmx4G -Xms2G -DwildcardSuites=$MAVEN_SUITES
-XX:+UnlockDiagnosticVMOptions -XX:+ShowMessageBoxOnError
-XX:+HeapDumpOnOutOfMemoryError -XX:ErrorFile=./hs_err_pid%p.log"
SPARK_HOME=`pwd` ./mvnw -B clean install ${{ inputs.maven_opts }}
+
+ - name: Check for documentation changes
+ shell: bash
+ run: |
+ # Check if any files in docs/ have been modified after Maven build
(which runs GenerateDocs)
+ if [ -n "$(git status --porcelain -- docs/)" ]; then
+ echo "❌ Documentation files have been modified after Maven build:"
+ git diff --name-only -- docs/
+ echo ""
+ echo "This suggests that config defaults have changed but the
documentation wasn't updated."
+ echo "Please run 'make jvm' locally and commit the updated
documentation files."
+ exit 1
+ else
+ echo "✅ Documentation is up-to-date"
Review Comment:
Super minor nitpick to probably remove the emojis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
