rluvaton opened a new pull request, #17592: URL: https://github.com/apache/datafusion/pull/17592
## Which issue does this PR close? N/A ## Rationale for this change I want fast grouping when there are a lot of columns to group by and there are a lot of unique groups ## What changes are included in this PR? This optimization is fairly simple: if the row indices to append are continues (i.e. `append_row_indices[i] + 1 == append_row_indices[i + 1]`) we will call an optimized function for that case the optimized function should copy all the data in a single pass making it very fast as opposed to item by item ## Are these changes tested? Existing tests but I want to add more, before I do I wanna see the benchmark results (I'm 99% it will be faster but still) ## Are there any user-facing changes? Nope -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
