alamb opened a new issue, #17685:
URL: https://github.com/apache/datafusion/issues/17685
Nice, I imagine if we wanted to support the rest of the type variations it
would look something like:
```rust
0 => match lit.type_variation_reference {
TIME_32_TYPE_VARIATION_REF => {
ScalarValue::Time32Second(Some(pt.value as i32))
}
others => {
return substrait_err!("Unknown type variation reference
{others}");
}
},
3 => match lit.type_variation_reference {
TIME_32_TYPE_VARIATION_REF => {
ScalarValue::Time32Millisecond(Some(pt.value as i32))
}
others => {
return substrait_err!("Unknown type variation reference
{others}");
}
},
```
If you are up for the ride I think we could also add them, otherwise I think
it's fine as is
_Originally posted by @gabotechs in
https://github.com/apache/datafusion/pull/17655#discussion_r2362591605_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
