alamb commented on PR #17563:
URL: https://github.com/apache/datafusion/pull/17563#issuecomment-3306856627
I am pretty torn on this PR
It clearly solves the planning time problem: (186x speedup!)
```
physical_window_function_partition_by_4_on_values 1.00 563.3±5.87µs
? ?/sec 2.39 1345.8±26.76µs ?
?/sec
physical_window_function_partition_by_7_on_values 1.00 683.9±3.80µs
? ?/sec 51.43 35.2±0.17ms ?
?/sec
physical_window_function_partition_by_8_on_values 1.00 733.7±2.76µs
? ?/sec 186.86 137.1±0.89ms
? ?/sec
```
But it also causes a potential regression by resorting data during query time
Woudl it be possible to do some sort of half-way solution, like maybe allow
up to 4 window functions, and above that turn off the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
