findepi commented on PR #17476: URL: https://github.com/apache/datafusion/pull/17476#issuecomment-3275464684
> if you dont provide distinct count, we require you to provide range. however, we accept even an unbounded range, which is kind of no information - in that case we just use the row count as our guess, basically. That's a good observation. This explains test changes I got after removal of the condition block, rather than make it more complicated. - https://github.com/apache/datafusion/blob/a951fc9c33416a6b240bf24a0120fce3ca37914f/datafusion/physical-plan/src/joins/utils.rs#L566-L573 So maybe we remove the condition after all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
