findepi commented on code in PR #17538:
URL: https://github.com/apache/datafusion/pull/17538#discussion_r2355687289
##########
.github/workflows/rust.yml:
##########
@@ -786,9 +818,44 @@ jobs:
run: cargo msrv --output-format json --log-target stdout verify
typos:
name: Spell Check with Typos
+ needs: [pre-job]
+ if: needs.pre-job.outputs.should_skip != 'true'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
with:
persist-credentials: false
- uses: crate-ci/typos@v1
+
+ rust-required-checks:
+ name: Validate Rust Required Checks
+ needs: [ linux-rustdoc,
+ linux-wasm-pack,
+ linux-build-lib,
+ macos-aarch64,
+ vendor,
+ check-fmt,
+ msrv,
+ linux-datafusion-common-features,
+ linux-datafusion-substrait-features,
+ linux-datafusion-proto-features,
+ linux-cargo-check-datafusion,
+ linux-cargo-check-datafusion-functions,
+ linux-test,
+ linux-test-example,
+ linux-test-doc,
+ verify-benchmark-results,
+ sqllogictest-postgres,
+ sqllogictest-substrait,
+ test-datafusion-pyarrow,
+ clippy,
+ cargo-toml-formatting-checks,
+ linux-test-datafusion-cli,
+ config-docs-check
+ ]
Review Comment:
we should have a test (eg in rust, using a yaml parser) to validate this
list is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
