iffyio commented on code in PR #2032: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2032#discussion_r2355439850
########## CHANGELOG.md: ########## @@ -27,7 +27,9 @@ Given that the parser produces a typed AST, any changes to the AST will technically be breaking and thus will result in a `0.(N+1)` version. -- Unreleased: Check https://github.com/sqlparser-rs/sqlparser-rs/commits/main for undocumented changes. +- Unreleased: Review Comment: I think we can revert this diff, the changelog is handled separately upon release. ########## src/ast/query.rs: ########## @@ -2267,6 +2267,7 @@ impl fmt::Display for Join { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { fn prefix(constraint: &JoinConstraint) -> &'static str { match constraint { + JoinConstraint::Auto => "AUTO ", Review Comment: Hi @justhaug could you add some context around this syntax and a link to the documentation that supports it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
