andygrove commented on PR #2397: URL: https://github.com/apache/datafusion-comet/pull/2397#issuecomment-3299152246
> > > * New `CometFuzzTestBase` extracted from `CometFuzzTestSuite` > > > > > > Oh I love this. > > > This PR fixes some old tech debt around the way we implemented `COUNT` aggregates. Originally, we tried using DataFusion's count aggregate but it was extremely slow when integrated into Comet. > > > > > > Did we try if performance improved at all recently? How long ago was this? > > This was ~1 year ago. See #744 for more information. Count was ~10x slower than Sum at the time (but only when integrated with Comet). I've moved this PR to draft for now. I will split out the testing changes into a separate PR and then experiment again with using DataFusion's count. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
