mbutrovich commented on code in PR #2286:
URL: https://github.com/apache/datafusion-comet/pull/2286#discussion_r2353163786
##########
native/spark-expr/src/predicate_funcs/rlike.rs:
##########
@@ -47,19 +46,19 @@ pub struct RLike {
pattern: Regex,
}
-impl Hash for RLike {
- fn hash<H: Hasher>(&self, state: &mut H) {
- state.write(self.pattern_str.as_bytes());
+impl PartialEq for RLike {
+ fn eq(&self, other: &Self) -> bool {
+ self.pattern_str == other.pattern_str
}
}
-impl DynEq for RLike {
- fn dyn_eq(&self, other: &dyn Any) -> bool {
- if let Some(other) = other.downcast_ref::<Self>() {
Review Comment:
The old `DynEq` implementation did not look at the child. Is that expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
