rkrishn7 commented on code in PR #17452: URL: https://github.com/apache/datafusion/pull/17452#discussion_r2332051333
########## datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs: ########## @@ -1355,7 +1362,7 @@ async fn test_nested_hashjoin_dynamic_filter_pushdown() { - DataSourceExec: file_groups={1 group: [[test.parquet]]}, projection=[a, x], file_type=test, pushdown_supported=true - HashJoinExec: mode=Partitioned, join_type=Inner, on=[(c@1, d@0)] - DataSourceExec: file_groups={1 group: [[test.parquet]]}, projection=[b, c, y], file_type=test, pushdown_supported=true, predicate=DynamicFilterPhysicalExpr [ b@0 >= aa AND b@0 <= ab ] - - DataSourceExec: file_groups={1 group: [[test.parquet]]}, projection=[d, z], file_type=test, pushdown_supported=true, predicate=DynamicFilterPhysicalExpr [ d@0 >= ca AND d@0 <= ce ] Review Comment: Ah I believe this is simply due to the fact that the filter is now applied in `TestOpener`. The bounds on the left side have changed due to rows being filtered out so we're seeing the correct filter now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org