pepijnve commented on code in PR #17419:
URL: https://github.com/apache/datafusion/pull/17419#discussion_r2337778725
##########
datafusion/sqllogictest/test_files/window.slt:
##########
@@ -3532,7 +3532,7 @@ physical_plan
01)BoundedWindowAggExec: wdw=[sum(multiple_ordered_table.a) ORDER BY
[multiple_ordered_table.b ASC NULLS LAST] RANGE BETWEEN UNBOUNDED PRECEDING AND
CURRENT ROW: Field { name: "sum(multiple_ordered_table.a) ORDER BY
[multiple_ordered_table.b ASC NULLS LAST] RANGE BETWEEN UNBOUNDED PRECEDING AND
CURRENT ROW", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered:
false, metadata: {} }, frame: RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT
ROW], mode=[Sorted]
02)--CoalesceBatchesExec: target_batch_size=4096
03)----FilterExec: b@2 = 0
-04)------DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/core/tests/data/window_2.csv]]}, projection=[a0, a,
b, c, d], output_orderings=[[a@1 ASC NULLS LAST, b@2 ASC NULLS LAST], [c@3 ASC
NULLS LAST]], file_type=csv, has_header=true
+04)------DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/core/tests/data/window_2.csv]]}, projection=[a0, a,
b, c, d], output_orderings=[[c@3 ASC NULLS LAST], [a@1 ASC NULLS LAST, b@2 ASC
NULLS LAST]], file_type=csv, has_header=true
Review Comment:
No, I didn't take the time to try to understand why. That's how they're
being emitted by the EquivalenceClass code. I had assumed the order was not
important, but if it is I can take a closer look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
