petern48 commented on issue #17503: URL: https://github.com/apache/datafusion/issues/17503#issuecomment-3275950825
For 1), I found a nice docstring here about what this is https://github.com/apache/datafusion/blob/a1709b6ead53f97d7a33418508232b01d61e754a/datafusion/optimizer/src/common_subexpr_eliminate.rs#L39-L45 I think it is intentional since that value explicitly comes up in tests like this: https://github.com/apache/datafusion/blob/a1709b6ead53f97d7a33418508232b01d61e754a/datafusion/sqllogictest/test_files/cse.slt#L27-L35 To me, it makes sense to keep it this way. Showing it in the logical / physical plans is useful to see whether the optimization is being applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
