hsiang-c commented on code in PR #2346:
URL: https://github.com/apache/datafusion-comet/pull/2346#discussion_r2331580405
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -239,6 +239,87 @@ impl ScanExec {
let mut timer = arrow_ffi_time.timer();
+ // Check for selection vectors and get selection indices if needed from
+ // JVM via FFI
+ // Selection vectors can be provided by, for instance, Iceberg to
+ // remove rows that have been deleted.
+ let selection_indices_arrays = Self::get_selection_indices(&mut env,
iter, num_cols)?;
+
+ // fetch batch data from JVMi via FFI
Review Comment:
(nit) `JVMi`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
