wForget commented on code in PR #2316:
URL: https://github.com/apache/datafusion-comet/pull/2316#discussion_r2329214232
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -172,7 +172,18 @@ object QueryPlanSerde extends Logging with CometExprShim {
classOf[OctetLength] -> CometScalarFunction("octet_length"),
classOf[Reverse] -> CometScalarFunction("reverse"),
classOf[StringRPad] -> CometStringRPad,
+
+ // GetDateField functions
classOf[Year] -> CometYear,
+ classOf[Month] -> CometMonth,
+ classOf[DayOfMonth] -> CometDayOfMonth,
+ classOf[DayOfWeek] -> CometDayOfWeek,
+ // FIXME: current datafusion version does not support isodow (WeekDay)
+ // , see: https://github.com/apache/datafusion-comet/issues/2330
+ // classOf[WeekDay] -> CometWeekDay,
Review Comment:
Filed https://github.com/apache/datafusion-comet/issues/2330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
