rkrishn7 commented on code in PR #17371:
URL: https://github.com/apache/datafusion/pull/17371#discussion_r2323972667
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -837,7 +842,6 @@ impl ExecutionPlan for HashJoinExec {
)?,
// Keep the dynamic filter, bounds accumulator will be reset
dynamic_filter: self.dynamic_filter.clone(),
Review Comment:
> We could, but I'm not sure that's a case we'll ever hit. When would
with_new_children be called after execution has started?
Yeah, while probably possible from a usage perspective I agree it's
unrealistic.
> FWIW this should never cause incorrect results, just disable the
optimization (the filter never gets updated).
Good point - I guess the downside is just the stale `dynamic_filter` being
left around in the case it becomes orphaned. But that's probably not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
