findepi commented on code in PR #17339:
URL: https://github.com/apache/datafusion/pull/17339#discussion_r2320105545
##########
typos.toml:
##########
@@ -0,0 +1,46 @@
+[default.extend-words]
+# random words from unit tests
+Pn = "Pn"
+fo = "fo"
+nd = "nd"
+Nd = "Nd"
+ba = "ba"
+ECT = "ECT"
+Ue = "Ue"
+Iy = "Iy"
+hte = "hte"
+numer = "numer"
Review Comment:
Looks like "number" with 'b' lost. Can we remove this?
##########
typos.toml:
##########
@@ -0,0 +1,46 @@
+[default.extend-words]
+# random words from unit tests
+Pn = "Pn"
+fo = "fo"
+nd = "nd"
+Nd = "Nd"
+ba = "ba"
+ECT = "ECT"
+Ue = "Ue"
+Iy = "Iy"
+hte = "hte"
+numer = "numer"
+abd = "abd"
+aroun = "aroun"
Review Comment:
Looks like "around" with last letter chopped off. Can we remove this?
##########
.github/workflows/rust.yml:
##########
@@ -781,3 +781,11 @@ jobs:
- name: Check datafusion-proto
working-directory: datafusion/proto
run: cargo msrv --output-format json --log-target stdout verify
+ typos:
+ name: Spell Check with Typos
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+ with:
+ persist-credentials: false
+ - uses: crate-ci/typos@v1
Review Comment:
Per https://infra.apache.org/github-actions-policy.html this should use
commit hash.
I am not sure
https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml
is normative. In any case, i read it as saying we can use the action. Not
saying that we can safely use the action without pinning to a hash.
##########
typos.toml:
##########
@@ -0,0 +1,46 @@
+[default.extend-words]
+# random words from unit tests
+Pn = "Pn"
+fo = "fo"
+nd = "nd"
+Nd = "Nd"
+ba = "ba"
+ECT = "ECT"
+Ue = "Ue"
+Iy = "Iy"
+hte = "hte"
+numer = "numer"
+abd = "abd"
+aroun = "aroun"
+abov = "abov"
+Ois = "Ois"
+alo = "alo"
+
+# abbreviations, common words, etc.
+typ = "typ"
+datas = "datas"
+YOUY = "YOUY"
+lits = "lits"
+
+# exposed to public API
+Serializeable = "Serializeable"
+
+# from test cases like TPC-* or ClickBench
+carefull = "carefull"
+precentage = "precentage"
Review Comment:
Can we remove these? These are clearly misspelled words that should be
flagged.
If they show up in some test data we don't want / can't modify, maybe we can
exclude-list that data set instead,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
