mbutrovich opened a new pull request, #2258:
URL: https://github.com/apache/datafusion-comet/pull/2258
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #1906.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
#1862 tried to implement RangePartitioning with native shuffle. The
implementation didn't work because executors calculated their own partition
boundaries.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This modifies the flow for the driver to calculate the boundaries (like
Spark). At a high level:
- Hoist code from Spark's `ShuffleExchangeExec` for using Spark's
`RangePartitioner` to calculate boundary rows.
- Serialize boundary rows to native side.
- Deserialize boundary rows and pass as part of the partitioning scheme.
Each executor should have the boundary values now.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
- New test implementing #1906.
## Remaining concerns
- What is the performance implication of iterating over these batches to
calculate the bounds at the driver? Are we introducing a bunch of overhead?
- Should we remove the code for calculating boundary rows in native code?
It's possible we (or someone else) might want this, so I left the tests and
annotated them to allow dead code.
- I change the default to enable this feature, but we can discuss setting it
to false. For now I want to see how it does in CI.
- I need to generate new plans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
