andygrove commented on code in PR #2211:
URL: https://github.com/apache/datafusion-comet/pull/2211#discussion_r2304050293
##########
dev/diffs/3.4.3.diff:
##########
@@ -894,6 +894,19 @@ index 525d97e4998..8a3e7457618 100644
AccumulatorSuite.verifyPeakExecutionMemorySet(sparkContext, "external
sort") {
sql("SELECT * FROM testData2 ORDER BY a ASC, b ASC").collect()
}
+@@ -4467,7 +4468,11 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
+ val msg = intercept[SparkException] {
+ sql(query).collect()
+ }.getMessage
+- assert(msg.contains(query))
++ if (!isCometEnabled) {
++ // Comet's error message does not include the original SQL query
++ // https://github.com/apache/datafusion-comet/issues/2215
++ assert(msg.contains(query))
Review Comment:
For Spark 3.x we previously fell back to Spark for this test because we do
not run the Spark SQL tests for 3.x with `ENABLE_COMET_ANSI_MODE=true` and
therefore did not enable `spark.comet.ansi.enabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
