kazuyukitanimura commented on code in PR #2211:
URL: https://github.com/apache/datafusion-comet/pull/2211#discussion_r2302340455
##########
dev/diffs/3.4.3.diff:
##########
@@ -894,6 +894,19 @@ index 525d97e4998..8a3e7457618 100644
AccumulatorSuite.verifyPeakExecutionMemorySet(sparkContext, "external
sort") {
sql("SELECT * FROM testData2 ORDER BY a ASC, b ASC").collect()
}
+@@ -4467,7 +4468,11 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
+ val msg = intercept[SparkException] {
+ sql(query).collect()
+ }.getMessage
+- assert(msg.contains(query))
++ if (!isCometEnabled) {
++ // Comet's error message does not include the original SQL query
++ // https://github.com/apache/datafusion-comet/issues/2215
++ assert(msg.contains(query))
Review Comment:
When ANSI was not enabled, was this passing?
If so, is there a way to check whether ANSI is enabled and skip only when
both comet and ansi are enabled?
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2368,13 +2368,13 @@ object QueryPlanSerde extends Logging with
CometExprShim {
sealed trait SupportLevel
-/** We support this feature with full compatibility with Spark */
+/** Comet supports this feature with full (or close enough) compatibility with
Spark */
Review Comment:
what is `close enough`??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
