timsaucer opened a new pull request, #17332: URL: https://github.com/apache/datafusion/pull/17332
## Which issue does this PR close? - Closes https://github.com/apache/datafusion/issues/15907 ## Rationale for this change For some users, adding in sqlparser greatly increases build times for their projects even though they are not using sql. This feature makes `sql` an optional dependency to improve build times and reduce the number of dependencies. ## What changes are included in this PR? Adds in a `sql` feature in the `core` crate and makes `sqlparser` an optional dependency. The rest of the changes are to account for the fact that some of the structs in `sqlparser` are used throughout the repository. ## Are these changes tested? Ideally this is effectively a no-op change. By enabling `sql` (or simply using the default features) there is no change and all tests should run as before. I have also run all tests with the `--no-default-features` flag. ## Are there any user-facing changes? There is one change that may be impactful to some users. By adding in the `sql` feature, if users are not using default features of the datafusion core crate, they will need to add `sql` to their `Cargo.toml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
