jonathanc-n commented on PR #16660: URL: https://github.com/apache/datafusion/pull/16660#issuecomment-3176949787
> Theoretically, as long as both the probe and build sides are sorted on the compare key (regardless of ASC or DESC), this operator should be able to execute, right? I think the current implementation is designed to enforce a certain ordering according to the inequality join predicate (by inserting a `SortExec` during planning). However, the buffer-side input might have the opposite order. For example, PMJ requires `t1` to be `ORDER BY c1 ASC`, but the existing order might be `ORDER BY c1 DESC`. I think this is a good idea, the logic may be a bit difficult for someone to look into the implementation to follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
