Blizzara commented on PR #17074: URL: https://github.com/apache/datafusion/pull/17074#issuecomment-3166003379
Thanks! The deprecation is sure an improvement, but I wonder if overall this is_nullable -> return type from args change suffers from the same issue as the earlier ones, namely that if a user implements a custom UDF overriding the is_nullable, they don’t see the deprecation warning and so their compiler won’t likely warn them to switch to the new one. If I remember correctly, the ”best” way I could figure out for these cases where - a new function is introduced in the (Scalar)UdfImpl interface and switched to internally, and - the new function does not by default delegate to the previously-internally-used function, would be to just remove the old function completely from the interface. Otherwise downstream implementors won’t get compile-time warnings, which is unfortunate. Obviously full removal has its own downsides too… (I may be also a bit rusty in my thinking, haven’t been working on this for a while anymore now.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
