andygrove commented on code in PR #2089:
URL: https://github.com/apache/datafusion-comet/pull/2089#discussion_r2261314132
##########
native/core/src/common/buffer.rs:
##########
@@ -31,16 +31,15 @@ use std::{
/// the unique owner for the memory it wraps. The holder of this buffer can
read or write the
/// buffer, and the buffer itself will be released when it goes out of scope.
///
-/// Also note that, in `owned` mode, the buffer is always filled with 0s, and
its length is always
-/// equal to its capacity. It's up to the caller to decide which part of the
buffer contains valid
-/// data.
+/// Also note that, in `owned` mode, the buffer is always filled with 0s. It's
up to the caller
+/// to decide which part of the buffer contains valid data.
///
/// If `owned` is false, this buffer is an alias to another buffer. The buffer
itself becomes
/// immutable and can only be read.
#[derive(Debug)]
pub struct CometBuffer {
data: NonNull<u8>,
- len: usize,
Review Comment:
It is invariant that `len == capacity`, so I removed `len`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
