andygrove commented on code in PR #2089:
URL: https://github.com/apache/datafusion-comet/pull/2089#discussion_r2261272582
##########
native/core/src/common/buffer.rs:
##########
@@ -71,25 +71,6 @@ impl CometBuffer {
}
}
- pub fn from_ptr(ptr: *const u8, len: usize, capacity: usize) -> Self {
Review Comment:
This function is only used in tests, so I moved it into the test module.
##########
native/core/src/common/buffer.rs:
##########
@@ -116,24 +97,6 @@ impl CometBuffer {
self
}
- /// Extends this buffer (must be an owned buffer) by appending bytes from
`src`,
- /// starting from `offset`.
- pub fn extend_from_slice(&mut self, offset: usize, src: &[u8]) {
Review Comment:
This function is only used in tests, so I moved it into the test module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
