mbutrovich commented on code in PR #2057:
URL: https://github.com/apache/datafusion-comet/pull/2057#discussion_r2261258597
##########
native/core/src/execution/planner.rs:
##########
@@ -474,6 +480,240 @@ impl PhysicalPlanner {
)))
}
}
+ },
+ Value::ListVal(values) => {
+ if let DataType::List(f) = data_type {
+ match f.data_type() {
+ DataType::Null => {
+
SingleRowListArrayBuilder::new(Arc::new(NullArray::new(values.clone().null_mask.len())))
+ .build_list_scalar()
+ }
+ DataType::Boolean => {
Review Comment:
Can we skip builders entirely? Does this get you equivalent behavior?
```
DataType::Boolean => {
let arr =
BooleanArray::new(values.clone().boolean_values.into(),Some(values.clone().null_mask.into()));
SingleRowListArrayBuilder::new(Arc::new(arr)).build_list_scalar()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
