iffyio commented on code in PR #1942:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1942#discussion_r2231345244
##########
src/dialect/snowflake.rs:
##########
@@ -427,6 +503,21 @@ impl Dialect for SnowflakeDialect {
}
}
+ fn is_table_factor(&self, kw: &Keyword, parser: &mut Parser) -> bool {
+ match kw {
+ Keyword::LIMIT
+ if matches!(
+ parser.peek_token().token,
+ Token::Number(_, _) | Token::Placeholder(_)
+ ) =>
Review Comment:
would it make sense to use the
[peek_for_limit_options](https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/dialect/snowflake.rs#L483C4-L491)
helper method here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
