alamb commented on code in PR #16803:
URL: https://github.com/apache/datafusion/pull/16803#discussion_r2214384501
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -433,7 +433,7 @@ impl ListingTableConfig {
/// `SchemaAdapterFactory` is set, in which case only the
`SchemaAdapterFactory` will be used.
///
/// See <https://github.com/apache/datafusion/issues/16800> for details on
this transition.
- pub fn with_physical_expr_adapter_factory(
+ pub fn with_expr_adapter_factory(
Review Comment:
I love this explanation -- I have found trying to write out examples of
using APIs almost always leads to discoveries of ways to improve them for the
better. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
