achristmascarl commented on code in PR #1947:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1947#discussion_r2213786861
##########
src/ast/ddl.rs:
##########
@@ -351,6 +351,10 @@ pub enum AlterTableOperation {
ValidateConstraint {
name: Ident,
},
+ /// `SET ( storage_parameter [= value] [, ... ] )`
Review Comment:
so Postgres does expect one of a specific set of parameters there:
https://www.postgresql.org/docs/current/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS
and will give `ERROR: unrecognized parameter` for an unexpected parameter.
The parameters also have been the same in the last 5 versions, so they seem
relatively stable.
Happy to either change to the more generic form, or update the parsing to
look for the specific storage parameters instead of arbitrary options. Whatever
you think is more appropriate @iffyio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
