iffyio commented on code in PR #1947: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1947#discussion_r2212658558
########## src/ast/ddl.rs: ########## @@ -351,6 +351,10 @@ pub enum AlterTableOperation { ValidateConstraint { name: Ident, }, + /// `SET ( storage_parameter [= value] [, ... ] )` Review Comment: Could we include a link to the docs where this syntax comes from? Also I'm wondering whether storageparameter is right terminology here? From what I can tell with the syntax it looks possible that it accepts arbitrary sql option in parenthesis? If so thinking something generic like `SetOptionsParens { options: Vec<SqlOption> }` or similar naming as the enum variant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org