adriangb commented on issue #16800: URL: https://github.com/apache/datafusion/issues/16800#issuecomment-3084230441
> Could you clarify the latter two? From your description, they sound like areas where `PhysicalExprAdapter` could bring benefits — but I'm not quite sure how `SchemaAdapter` fits into those cases. There's some discussion in https://github.com/apache/datafusion/issues/14993. Basically if we want to be able to customize how expressions are evaluated for a specific format, in particular how `variant_get(column, 'field')` or `get_field(column, 'field')` are executed in the context of a specific format (e.g. in parquet we can read single struct columns or use shredded variant) we need to have access to the expression in ParquetOpener in order to check if the file schema has the shredded variant field and generate the right ProjectionMask. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
