coderfender commented on code in PR #1996:
URL: https://github.com/apache/datafusion-comet/pull/1996#discussion_r2196418290
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -677,7 +677,13 @@ object QueryPlanSerde extends Logging with CometExprShim {
}
None
- case div @ IntegralDivide(left, right, _) if
supportedDataType(left.dataType) =>
Review Comment:
The fix essentially mimcs Spark's behavior to have divide operands being
casted to DoubleType (except for Decimal type)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
