mbutrovich commented on code in PR #1887:
URL: https://github.com/apache/datafusion-comet/pull/1887#discussion_r2192800452
##########
spark/src/test/scala/org/apache/comet/CometStringExpressionSuite.scala:
##########
@@ -185,4 +186,67 @@ class CometStringExpressionSuite extends CometTestBase {
}
}
+ // Modified from Spark test "filter pushdown - StringPredicate"
+ private def testStringPredicate(
Review Comment:
It can't in the version that we brought over from Spark. In the Spark SQL
test it relies on the accumulator class to verify, which I don't think Comet
has access to. That's why I'm wondering if I should even bring the test over or
rely on the Spark SQL version.
##########
native/proto/src/proto/operator.proto:
##########
@@ -110,6 +110,7 @@ message Projection {
message Filter {
spark.spark_expression.Expr predicate = 1;
bool use_datafusion_filter = 2;
+ bool wrap_child_in_copy_exec = 3;
Review Comment:
Sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
