comphead commented on code in PR #1887: URL: https://github.com/apache/datafusion-comet/pull/1887#discussion_r2192767215
########## spark/src/test/scala/org/apache/comet/CometStringExpressionSuite.scala: ########## @@ -185,4 +186,67 @@ class CometStringExpressionSuite extends CometTestBase { } } + // Modified from Spark test "filter pushdown - StringPredicate" + private def testStringPredicate( Review Comment: how exactly the test checks that pushdown was triggered? 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org