fvj opened a new pull request, #16687: URL: https://github.com/apache/datafusion/pull/16687
## Which issue does this PR close? None. It's too small of a change for an issue, in my opinion. Happy to retroactively create one, though. ## Rationale for this change unfortunately, the current `Dockerfile` does not set the `PATH` variable correctly. the `RUN` directive is evaluated at build time. thus, the `$HOME` variable is resolved correctly to `/root/` when installing the `protoc` binary; the binary ends up in `/root/.local/bin/protoc`. in contrast, an `ENV` directive is evaluated at a container's runtime, so if `$HOME` is not correctly set at runtime, the `PATH` addition `$HOME/.local/bin` resolves to `/.local/bin`, which does not exist. ## What changes are included in this PR? - change the way the devcontainer's Docker image installs `protoc` from "from-source" to using the base image's (debian bookworm) package repository, in line with [1]. - downgrade from protoc v3.25.1 to v3.21.12. the docs [1] say any version above v3.15 is fine. [1] https://datafusion.apache.org/contributor-guide/development_environment.html#protoc-installation ## Are these changes tested? Yes. I tested the container to check if the `protoc` binary is found: ```bash $ docker build . -t datafusion-devcontainer:latest &>/dev/null && \ docker run --rm -it datafusion-devcontainer:latest protoc --version libprotoc 3.21.12 ``` Additionally, I used the devcontainer to build DataFusion inside the devcontainer. ## Are there any user-facing changes? No, none. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
