yoavcloud opened a new pull request, #1924: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1924
We've encountered a problem parsing statements like `SELECT 1, sort FROM tbl` which are valid in Snowflake. The reason is that in the Snowflake dialect, supports_projection_trailing_commas is `true`. The flow then checks the keyword after the comma to see if it's reserved (`FROM` for example), and if not, it stops parsing the projection. However, the check relies on `Dialect::is_column_alias` which wasn't implemented in the Snowflake dialog. The solution is to align the behavior of the Snowflake dialect to other dialects by overriding `Dialect::is_column_alias` instead of `Dialect::is_select_item_alias`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
