kazuyukitanimura commented on code in PR #1987:
URL: https://github.com/apache/datafusion-comet/pull/1987#discussion_r2183864520
##########
dev/diffs/iceberg/1.8.1.diff:
##########
@@ -195,6 +195,100 @@ index e2d2c7a..d23acef 100644
relocate 'org.apache.orc', 'org.apache.iceberg.shaded.org.apache.orc'
relocate 'io.airlift', 'org.apache.iceberg.shaded.io.airlift'
relocate 'org.apache.hc.client5',
'org.apache.iceberg.shaded.org.apache.hc.client5'
+diff --git
a/spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java
b/spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java
+index 578845e..9476f19 100644
+---
a/spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java
++++
b/spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java
+@@ -57,6 +57,8 @@ public abstract class ExtensionsTestBase extends
CatalogTestBase {
+
.config("spark.sql.legacy.respectNullabilityInTextDatasetConversion", "true")
+ .config(
+ SQLConf.ADAPTIVE_EXECUTION_ENABLED().key(),
String.valueOf(RANDOM.nextBoolean()))
++ .config("spark.plugins", "org.apache.spark.CometPlugin")
Review Comment:
This makes sense but could be error prone. If there is a new test that uses
spark session, we miss enabling it.
Wondering if there is a good way to update all spark session at once...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
