corwinjoy commented on PR #16649: URL: https://github.com/apache/datafusion/pull/16649#issuecomment-3033798159
> Thanks @corwinjoy ! I have a few suggestions on how to maybe make this code a bit easier to deal with -- let me know what you think > > I think this would benefit from: > > 1. A test that all the cfg'ing is working by adding to the CI here: https://github.com/apache/datafusion/blob/e063a8d95841aadcb337b99e6c2b4581a811a318/.github/workflows/rust.yml#L204 > 2. Documentation about this rust feature: https://github.com/apache/datafusion/blob/56c1a09bff1eae188486c747404f163353c1bfd4/README.md#L111-L110 Sounds good! I have added this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
