findepi commented on PR #16639: URL: https://github.com/apache/datafusion/pull/16639#issuecomment-3029132694
@Omega359 i am not exactly fan of the cast semantics. If i were to choose, i would choose it to be different. Note that it's pre-existing though: Consider - cast source type float 32, float 64 - cast target type timestamp seconds / millis / micros / nanos - in scalar (constant folding) or query context from these 16 combinations, this PR changes only one, to make it consistent with other 15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
