findepi commented on PR #16639: URL: https://github.com/apache/datafusion/pull/16639#issuecomment-3024507747
@jatin510 thanks for feedback. `to_timestamp(a_double)`, `to_timestamp_seconds(a_double)` and `cast(a_double as timestamp)` are 3 different things that do not have to behave the same. it's nice if they do however, `cast(a_double as timestamp)` **must** behave the same as `cast(a_double as timestamp)`... which clearly is a problem now: https://github.com/apache/datafusion/issues/16636 moreover, `cast(a_double as timestamp(p))` **must** behave reasonably consistently for various `p` values (another clear problem today) also cast from a double (Float64) **must** behave consistently with a cast from a float (Float32) (will add test coverage for that) i am not really changing `cast(a_double as timestamp)` cast. I am only changing a specialized incorrect code path that's taken by that cast under very specific and narrow cirumstances. this should be a non-controvercial -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
