andygrove commented on code in PR #1830: URL: https://github.com/apache/datafusion-comet/pull/1830#discussion_r2180120589
########## common/src/test/java/org/apache/comet/parquet/TestFileReader.java: ########## @@ -609,7 +611,9 @@ public void testColumnIndexReadWrite() throws Exception { assertEquals(1, offsetIndex.getFirstRowIndex(1)); assertEquals(3, offsetIndex.getFirstRowIndex(2)); - assertNull(indexReader.readColumnIndex(footer.getBlocks().get(2).getColumns().get(0))); + if (!isSpark40Plus()) { + assertNull(indexReader.readColumnIndex(footer.getBlocks().get(2).getColumns().get(0))); Review Comment: The code here has a TODO linking to https://github.com/apache/datafusion-comet/issues/1948. I added a comment in this issue referring to this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org