huaxingao commented on code in PR #1830:
URL: https://github.com/apache/datafusion-comet/pull/1830#discussion_r2176170903
##########
pom.xml:
##########
@@ -1074,9 +1074,19 @@ under the License.
<ignoreClass>javax.annotation.meta.TypeQualifierNickname</ignoreClass>
</ignoreClasses>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <ignoreClasses>
+
<ignoreClass>com.google.thirdparty.publicsuffix.TrieParser</ignoreClass>
+
<ignoreClass>com.google.thirdparty.publicsuffix.PublicSuffixPatterns</ignoreClass>
+
<ignoreClass>com.google.thirdparty.publicsuffix.PublicSuffixType</ignoreClass>
Review Comment:
I ignored these classes to get around the following errors.
```
[ERROR] Rule 2:
org.codehaus.mojo.extraenforcer.dependencies.BanDuplicateClasses failed with
message:
[ERROR] Duplicate classes found:
[ERROR]
[ERROR] Found in:
[ERROR] org.apache.spark:spark-network-common_2.13:jar:4.0.0:provided
[ERROR] com.google.guava:guava:jar:33.2.1-jre:compile
[ERROR] Duplicate classes:
[ERROR] com/google/thirdparty/publicsuffix/TrieParser.class
[ERROR] com/google/thirdparty/publicsuffix/PublicSuffixPatterns.class
[ERROR] com/google/thirdparty/publicsuffix/PublicSuffixType.class
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
