alamb commented on PR #16395: URL: https://github.com/apache/datafusion/pull/16395#issuecomment-3027588395
Hi @zhuqi-lucas -- spent a while this morning going over this PR carefully -- it is great! I hope you don't mind but I made some substantial edits to try and make it read a bit better: 1. Revamped the documentation and overview 2. Updated the ASCII art 3. moved reading the index into DistinctIndex 4. Added a bunch more comments 5. Simplified the code to only write the offset index (the length is stored inline) In my mind none of this was required but since I plan to make a Huge Deal (TM) about this example publically I figured spending some extra time polishing it would be worthwhle - [54a9e61](https://github.com/apache/datafusion/pull/16395/commits/54a9e610ed64448f95fe8526129871c63a8efcff) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
