Dandandan commented on PR #16647:
URL: https://github.com/apache/datafusion/pull/16647#issuecomment-3027527429

   
   > I made the following changes to allow the test to support returning 8192 
rows each time: 
![Clipboard_Screenshot_1751455219](https://private-user-images.githubusercontent.com/73544345/461496890-85e2f088-3ad5-4756-8681-f4e94ead6593.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTE0NTYwNDQsIm5iZiI6MTc1MTQ1NTc0NCwicGF0aCI6Ii83MzU0NDM0NS80NjE0OTY4OTAtODVlMmYwODgtM2FkNS00NzU2LTg2ODEtZjRlOTRlYWQ2NTkzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA3MDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNzAyVDExMjkwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI2YjljZmRkODkzMzg0ZmY4NGRlNTY5MGZjMjg3YjUxOGNhMjUzZWEwN2U4MzQ5ZjdhYjBkYjc0MjNlMjhjNmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qntimEEj5xhNtvEeu35i4t0ledHnJJLAQGgRkDJvFds)
   > 
   > I found that reducing the length of the string at this point hardly 
improves performance, and keeping the original length still results in little 
change in performance:
   > 
   > ```
   
   
   Hmm... I meant changing the benchmark to create **multiple** batches, rather 
than a single larger or smaller one.
   The SPM can only reuse allocations when there is conversion of previous 
batches to reuse the allocation from.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to