acking-you commented on PR #16647: URL: https://github.com/apache/datafusion/pull/16647#issuecomment-3027510420
I made the following changes to allow the test to support returning 8192 rows each time:  I found that reducing the length of the string at this point hardly improves performance, and keeping the original length still results in little change in performance: ```sh bench_merge_sorted_preserving/multiple_large_string_columns_with_1m_rows time: [23.693 ms 24.160 ms 24.802 ms] bench_merge_sorted_preserving/multiple_u64_columns_with_1m_rows time: [2.9874 ms 2.9921 ms 2.9993 ms] ➜ arrow-datafusion git:(main) git checkout reuse_rows root@VM-250-221-tencentos arrow-datafusion # Switched to branch 'reuse_rows bench_merge_sorted_preserving/multiple_large_string_columns_with_1m_rows time: [23.796 ms 24.339 ms 24.601 ms] change: [-4.5659% -2.0603% +0.7308%] (p = 0.17 > 0.05) No change in performance detected. bench_merge_sorted_preserving/multiple_u64_columns_with_1m_rows time: [2.9963 ms 3.0421 ms 3.0962 ms] change: [-0.7491% +0.3715% +1.7710%] (p = 0.62 > 0.05) No change in performance detected. Found 1 outliers among 10 measurements (10.00%) 1 (10.00%) high severe ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
