blaginin commented on code in PR #16617:
URL: https://github.com/apache/datafusion/pull/16617#discussion_r2178602504
##########
datafusion/core/tests/physical_optimizer/sanity_checker.rs:
##########
@@ -445,10 +443,15 @@ async fn test_bounded_window_agg_no_sort_requirement() ->
Result<()> {
},
)];
let bw = bounded_window_exec("c9", sort_exprs, source);
- assert_plan(bw.as_ref(), vec![
- "BoundedWindowAggExec: wdw=[count: Ok(Field { name: \"count\",
data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false,
metadata: {} }), frame: WindowFrame { units: Range, start_bound:
Preceding(UInt64(NULL)), end_bound: CurrentRow, is_causal: false }],
mode=[Sorted]",
- " DataSourceExec: partitions=1, partition_sizes=[0]"
- ]);
+ let plan_str = displayable(bw.as_ref()).indent(true).to_string();
Review Comment:
Then you should be able to remove
```rust
let initial = get_plan_string(&projection).join("\n");
```
as it is doing a bit of pointless work: first splitting the lines and then
merging them together 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
